nagios-charmers team mailing list archive

[Alvaro Uria <alvaro.uria@xxxxxxxxxxxxx>]

Review: Needs Fixing

I've added a comment inline (minor issue re: a docstring).

OTOH, the official repo for lp:charm-nagios will have to be changed to lp:~llama-charmers/charm-nagios (I can do it after this MP is merged).

Diff comments:

> diff --git a/hooks/common.py b/hooks/common.py
> index b320880..fa241a6 100644
> --- a/hooks/common.py
> +++ b/hooks/common.py
> @@ -104,8 +104,8 @@ def get_ip_and_hostname(remote_unit, relation_id=None):
>  
>  
>  def refresh_hostgroups():  # noqa:C901
> -    """ Not the most efficient thing but since we're only
> -        parsing what is already on disk here its not too bad """
> +    """Not the most efficient thing but since we're only
> +    parsing what is already on disk here its not too bad"""

should we take the opportunity to reformat the docstring? A single line (summary) followed by a new paragraph (further info on what the function does).

>      hosts = [x["host_name"] for x in Model.Host.objects.all if x["host_name"]]
>  
>      hgroups = {}


-- 
https://code.launchpad.net/~afreiberger/charm-nagios/+git/nagios-charm/+merge/392352
Your team Nagios Charm developers is subscribed to branch charm-nagios:master.