nemos-team team mailing list archive

[Lucas Kanashiro <2034648@xxxxxxxxxxxxxxxxxx>]

I have some more comments on top of what seb said:

- Source package name: why did you decide to use optee-os-s32 when upstream
  names it as optee-os? I was not able to find the reason behind that decision.

- d/watch: it is not working properly:

$ uscan --verbose --download-version 3.18-bsp37.0
uscan info: uscan (version 2.20.2ubuntu2) See uscan(1) for help
uscan info: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="optee-os-s32" version="3.18-bsp37.0-5" (as seen in debian/changelog)
uscan info: package="optee-os-s32" version="3.18-bsp37.0" (no epoch/revision)
uscan info: ./debian/changelog sets package="optee-os-s32" version="3.18-bsp37.0"
uscan info: Process watch file at: debian/watch
    package = optee-os-s32
    version = 3.18-bsp37.0
    pkg_dir = .
uscan info: opts: filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/optee-os-s32-$2-$1\.tar\.gz/,uversionmangle=s/(bsp\d+\.\d+).(\d+\.\d+)/$2-$1/,
uscan info: line: https://github.com/nxp-auto-linux/optee_os/tags .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Parsing filenamemangle=s/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz/optee-os-s32-$2-$1\.tar\.gz/
uscan info: Parsing uversionmangle=s/(bsp\d+\.\d+).(\d+\.\d+)/$2-$1/
uscan info: line: https://github.com/nxp-auto-linux/optee_os/tags .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Last orig.tar.* tarball version (from debian/changelog): 3.18-bsp37.0
uscan info: Download the --download-version specified version: 3.18-bsp37.0
uscan info: Requesting URL:
   https://github.com/nxp-auto-linux/optee_os/tags
uscan info: Matching pattern:
   (?:(?:https://github.com)?\/nxp\-auto\-linux\/optee_os\/tags)?.*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz
uscan info: Found the following matching hrefs on the web page (newest first):
   /nxp-auto-linux/optee_os/archive/refs/tags/bsp38.0-3.18.tar.gz (3.18-bsp38.0) index=3.18-bsp38.0-1 
   /nxp-auto-linux/optee_os/archive/refs/tags/bsp37.0-3.18.tar.gz (3.18-bsp37.0) index=3.18-bsp37.0-1 matched with the download version
   /nxp-auto-linux/optee_os/archive/refs/tags/bsp36.0-3.18.tar.gz (3.18-bsp36.0) index=3.18-bsp36.0-1 
   /nxp-auto-linux/optee_os/archive/refs/tags/bsp35.0-3.18.tar.gz (3.18-bsp35.0) index=3.18-bsp35.0-1 
   /nxp-auto-linux/optee_os/archive/refs/tags/bsp34.2-3.11.tar.gz (3.11-bsp34.2) index=3.11-bsp34.2-1 
uscan info: Looking at $base = https://github.com/nxp-auto-linux/optee_os/tags with
    $filepattern = .*/(bsp\d+\.\d+)-(\d+\.\d+)\.tar\.gz found
    $newfile     = /nxp-auto-linux/optee_os/archive/refs/tags/bsp37.0-3.18.tar.gz
    $newversion  = 3.18-bsp37.0
    $lastversion = 3.18-bsp37.0
uscan info: Matching target for downloadurlmangle: https://github.com/nxp-auto-linux/optee_os/archive/refs/tags/bsp37.0-3.18.tar.gz
uscan info: Upstream URL(+tag) to download is identified as    https://github.com/nxp-auto-linux/optee_os/archive/refs/tags/bsp37.0-3.18.tar.gz
uscan info: Matching target for filenamemangle: /nxp-auto-linux/optee_os/archive/refs/tags/bsp37.0-3.18.tar.gz
uscan info: Filename (filenamemangled) for downloaded file: /nxp-auto-linux/optee_os/archive/refs/tags/optee-os-s32-3.18-bsp37.0.tar.gz
uscan: Newest version of optee-os-s32 on remote site is 3.18-bsp37.0, specified download version is 3.18-bsp37.0
uscan info: Downloading upstream package: /nxp-auto-linux/optee_os/archive/refs/tags/optee-os-s32-3.18-bsp37.0.tar.gz
uscan info: Requesting URL:
   https://github.com/nxp-auto-linux/optee_os/archive/refs/tags/bsp37.0-3.18.tar.gz
uscan info: Successfully downloaded package: /nxp-auto-linux/optee_os/archive/refs/tags/optee-os-s32-3.18-bsp37.0.tar.gz
uscan info: Start checking for common possible upstream OpenPGP signature files
uscan info: End checking for common possible upstream OpenPGP signature files
uscan info: Missing OpenPGP signature.
uscan info: New orig.tar.* tarball version (oversionmangled): 3.18-bsp37.0
uscan info: Launch mk-origtargz with options:
   --package optee-os-s32 --version 3.18-bsp37.0 --compression default --directory .. --copyright-file debian/copyright ..//nxp-auto-linux/optee_os/archive/refs/tags/optee-os-s32-3.18-bsp37.0.tar.gz
uscan error: Could not read ..//nxp-auto-linux/optee_os/archive/refs/tags/optee-os-s32-3.18-bsp37.0.tar.gz: No such file or directory

- d/changelog: this is a comment that may not result in any change but since
  this is a new package in the archive you could have just a single entry
  saying that this is the initial release. However, I do understand that you
  might want to keep the changes history from your PPA.

- d/control: you used your name and email in the Maintainer field but in Ubuntu
  we usually use Ubuntu Developers <ubuntu-devel-discuss@xxxxxxxxxxxxxxxx>. To
  do the right thing you should use update-maintainer script from
  ubuntu-dev-tools package.

- d/copyright: you should not add yourself as a copyright holder of debian/ if
  you did that in your work hours. Just Canonical should be the copyright
  holder.

-- 
You received this bug notification because you are a member of NemOS
Team, which is a bug assignee.
https://bugs.launchpad.net/bugs/2034648

Title:
  [needs-packaging] optee-os-s32

Status in Ubuntu:
  In Progress

Bug description:
  [needs-packaging] optee-os-s32 (3.18-bsp37.0-5+nemos~202310131252~ubuntu23.10.1)
  For Erlangen project, we have to provide the NXP S32G OP-TEE OS to the customer via Ubuntu archive (universe).

  URL: https://launchpad.net/~nemos-team/+archive/ubuntu/ppa/+packages
  Source code: https://code.launchpad.net/~nemos-team/nemos/+git/optee-os-s32/+ref/ubuntu/devel
  License: https://git.launchpad.net/~nemos-team/nemos/+git/optee-os-s32/tree/debian/copyright
  Notes: The NXP S32G OP-TEE OS [Mantic]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2034648/+subscriptions