netplan-developers team mailing list archive

Thread
Date

Re: [Merge] ~morphis/netplan/+git/netplan:nm-snap-support into netplan:master

To: Simon Fels <simon.busch@xxxxxxxxxxxxx>
From: Martin Pitt <martin.pitt@xxxxxxxxxx>
Date: Mon, 26 Sep 2016 20:35:12 -0000
In-reply-to: <20160923110533.4637.85765.launchpad@ackee.canonical.com>
Reply-to: mp+306607@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

I'm sorry, but this is just broken. That binary name is being used way more widely than the .service name. If you want to credibly provide an OS component as a snap, then this also must provide the expected API, CLI, etc. to the user. Note that it already is not possible to install this on touch, or a "personal" snappy device etc. which has network-manager.deb installed. I. e. it's going to clash anyway, so you can as well provide the proper executable names.
-- 
https://code.launchpad.net/~morphis/netplan/+git/netplan/+merge/306607
Your team Developers of netplan is subscribed to branch netplan:master.

References

[Merge] ~morphis/netplan/+git/netplan:nm-snap-support into netplan:master
From: Simon Fels, 2016-09-23