netplan-developers team mailing list archive

[Steve Langasek <steve.langasek@xxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> diff --git a/debian/postinst b/debian/postinst
> new file mode 100644
> index 0000000..6e46b63
> --- /dev/null
> +++ b/debian/postinst
> @@ -0,0 +1,25 @@
> +#!/bin/sh
> +
> +set -e
> +set -u
> +
> +case "$1" in
> +    configure)

This needs guarded with a version check.  We should only create this file once on upgrade, and not re-create it repeatedly if the admin has removed the file.

> +	# Create /etc/network/interfaces as breadcrumbs if it doesn't
> +	# already exist
> +	if [ ! -f /etc/network/interfaces ]; then
> +		cat <<EOF >/etc/network/interfaces
> +# ifupdown has been replaced by netplan in new Ubuntu releases.
> +# Network configuration is now written in files (in YAML format), in the
> +# /etc/netplan directory.
> +# Please see 'man 5 netplan' for more information.

Suggested consistency with other such banners (/etc/resolv.conf):

# ifupdown has been replaced by netplan(5) on this system.  Do not edit.

I don't think we need to put any more here than a pointer to the netplan manpage - that reduces the risk that we will have to change the file later and manage multiple versions of the file with differing checksums on future cleanup.

> +EOF
> +	fi
> +	;;
> +    *)
> +	;;
> +esac
> +
> +#DEBHELPER#
> +
> +exit 0


-- 
https://code.launchpad.net/~netplan-developers/netplan/+git/netplan/+merge/332439
Your team Developers of netplan is subscribed to branch netplan:master.