← Back to team overview

nrtb-core team mailing list archive

[Bug 846069] Re: old c-style functions in common.cpp

 

The nrtb::tcp_socket and the nrtb::conf_reader are the primary users of
the functions listed above.

Oh and for the record these are NOT "C style" functions.. they are in
modern in both design and operation. They are type-safe, throw if they
have a problem, do not return status flags and use modern syntax and the
STL. They are free-standing functions, but that's the only only
similarity to classic "C" functions; they would not even compile in C.

So there! :)

-- 
You received this bug notification because you are a member of NRTB
Core, which is subscribed to New Real Time Battle.
https://bugs.launchpad.net/bugs/846069

Title:
  old c-style functions in common.cpp

Status in The New Real Time Battle Project:
  Triaged

Bug description:
  ~/common/common_rl/common.cpp contains various c-style functions.  Among them are...
  changecase
  upcase
  downcase
  gsub
  split
  trim
  The components that call these functions should be modified to call the corresponding methods in the latest string class (which I think is part of STL, but I'm not sure).  Afterwards, these functions should perhaps be removed from common.cpp altogether.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nrtb/+bug/846069/+subscriptions


References