← Back to team overview

nunit-core team mailing list archive

Re: [Bug 603088] Re: NUnit Gui: Project Config Change from Menu Does Not Change AssemblyWatcher

 

Looks good at a glance. My usual Windows machine is in the shop so the
review and
merge will have to wait till I finish setting up a VM.

Charlie

On Thu, Sep 9, 2010 at 11:45 AM, Cvetomir Todorov
<603088@xxxxxxxxxxxxxxxxxx> wrote:
> ** Changed in: nunitv2
>       Status: Triaged => Confirmed
>
> ** Changed in: nunitv2
>       Status: Confirmed => In Progress
>
> ** Changed in: nunitv2
>       Status: In Progress => Fix Committed
>
> --
> NUnit Gui: Project Config Change from Menu Does Not Change AssemblyWatcher
> https://bugs.launchpad.net/bugs/603088
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
>

-- 
NUnit Gui: Project Config Change from Menu Does Not Change AssemblyWatcher
https://bugs.launchpad.net/bugs/603088
You received this bug notification because you are a member of NUnit
Developers, which is subscribed to NUnit V2.

Status in NUnit V2 Test Framework: Fix Committed

Bug description:
- NUnit 2.5.5.10112
- nunit-x86.exe
- Windows 7 64 Bit.

Create an nunit project with two configurations: Debug and Release. Set each config to load one assembly but from different paths, for example:

win32\debug\some_assembly.dll
win32\release\some_assembly.dll

Save the project, when config is set to debug. Close and re-start nunit-x86.exe, load the project. Then modify your debug dll and observe how it gets reloaded by nunit. Then change the config to release in nunit and modify your release dll so that it should get reloaded by nunit. It does not. Then change the debug dll version again and observe how nunit reloads the assembly even though the config is still release.

I had a look into the sources (2.5.5.10112) and I think the bug is in NUnit.UtilTestLoader class in method NUnit.Util.TestLoader.ReloadTest(), it does not call InstallWatcher() like NUnit.Util.TestLoader.LoadTest() does.

I think ReloadTest and LoadTest methods need refactoring as the code is almost the same.

If someone can advise me how and where to add a unit test for this case, then I could try to do the fix and refactoring myself and post the result.





References