nunit-core team mailing list archive

[Francois Karman <fkmels-google@xxxxxxxx>]

Francois Karman has proposed merging lp:~faz/nunit-3.0/phone into lp:nunit-3.0.

Requested reviews:
  NUnit Core Developers (nunit-core)


This branch contains the changes to the nunitlite framework to work with Windows Phone.

This branch is compiled with the following compilation symbols: SILVERLIGHT;WINDOWS_PHONE;NUNITLITE;CLR_2_0;NETCF_1_0;NETCF
I use the NETCF_1_0 to provide a first working solution and improve it in a second step.

A new wp7 solution is provided to compile and run the unit tests of the framework.

Some choices should be reviewed:
1. The PhoneUI class that provides the same functionality than TextUI but for a framework that doesn't support a Main method.
To use TextUI the code line is: new TextUI(writer).Execute(args);
To use PhoneUI the code line can be: new PhoneUI(writer).AddAssembly(this.GetType().Assembly).Execute();

2. I provide a phone-runner package in the src folder
This folder is directly licked to the wp7/NUnitFramework solution and allows to start the unit tests of the framework.
I don't know if this package should remain or not.
To simply its removing, it is the last commit of the branch.

3. I have add some classes to provide missing features of the WP framework like XmlNode, ArrayList and ApplicationException.
Maybe there is already existing classes for those concepts? I see for sample that there is an existing ObjectList class that could maybe be used instead of ArrayList?
FYI: I put the classic copyright (c) 2010 Charlie Poole on top of the created files. Is this ok or should I put my name instead or yours?

4. usage of the WINDOWS_PHONE symbol.
I think that many of the WINDOWS_PHONE symbols can be replaced by SILVERLIGHT symbols.

5. I don't update NAnt scripts - I don't really know how it works :).
-- 
https://code.launchpad.net/~faz/nunit-3.0/phone/+merge/40694
Your team NUnit Core Developers is requested to review the proposed merge of lp:~faz/nunit-3.0/phone into lp:nunit-3.0.