nunit-core team mailing list archive

[Charlie Poole <charlie@xxxxxxxxx>]

Hi Jordan,

> 1. Can you give me steps to reproduce the error due to a null reference?

Simply run the NUnit tests - or select the tests for console runner for
a quicker test.

> 2. Go ahead and send me the fix.

I'll send it separately. Note that it's not a fix for your code, but for
the secondary error that arises when handling the exception. There could
be other places in TestSuite or elsewhere that assume that FixtureType
and possibly Fixture are not null.

> 4. More a matter of style, primarily because I only need a reference to the
> assembly during the construction of the TestAssembly - it is not needed after
> that.

OK

> 5. Agreed - the ordering with respect to inheritance needs to be fixed.

OK
 
> Thanks - Jordan
-- 
https://code.launchpad.net/~jterrell/nunitv2/action-attributes/+merge/43316
Your team NUnit Core Developers is requested to review the proposed merge of lp:~jterrell/nunitv2/action-attributes into lp:nunitv2.