← Back to team overview

nunit-core team mailing list archive

Re: [Bug 1057911] Re: Trap incorrect input for nunit-console.exe options.

 

I see, I can definitely create the files in the temp dir then.

Simone

On Sun, Oct 21, 2012 at 5:24 PM, Charlie Poole <charlie@xxxxxxxxx>
wrote:

> Because we distribute the tests and tell users to validate the
> installation by running them!
>
> Charlie
>
> On Sun, Oct 21, 2012 at 8:02 AM, Simone Busoli
> <1057911@xxxxxxxxxxxxxxxxxx> wrote:
> > Charlie, these are files which are used during the test. Why would you
> run
> > the tests from the installed package?
> >
> > On Sun, Oct 21, 2012 at 4:46 PM, Charlie Poole <charlie@xxxxxxxxx>
> > wrote:
> >
> >> Simone, This fix is causing a problem in the final release package, when
> >> NUnit is installed in the Program Files directory. We can't access the
> >> two text files you added due to security concerns. The best solution
> >> I've found in similar cases is to create the files on the fly in the
> >> temp directory and delete them afterwards. That would be best, if you
> >> have time. Otherwise, we can just drop those tests from the release.
> >>
> >> Charlie
> >>
> >> --
> >> You received this bug notification because you are a bug assignee.
> >> https://bugs.launchpad.net/bugs/1057911
> >>
> >> Title:
> >>   Trap incorrect input for nunit-console.exe options.
> >>
> >> Status in NUnit V2 Test Framework:
> >>   Fix Committed
> >>
> >> Bug description:
> >>   nunit-console.exe should handle incorrect options gracefully.  As of
> >>   now, it either runs 0 tests or throws an unhandled exception.
> >>
> >>   1) Specifically, for the /runlist option, the following is thrown:
> >>
> >>   /cygdrive/c/Program\ Files/NUnit\ 2.6.1/bin/nunit-console.exe
> >> /runlist=./EmptyLibrary/Class1.cs ./NUnit/bin/Debug/NUnit.dll
> >>   NUnit-Console version 2.6.1.12217
> >>   Copyright (C) 2002-2012 Charlie Poole.
> >>   Copyright (C) 2002-2004 James W. Newkirk, Michael C. Two, Alexei A.
> >> Vorontsov.
> >>   Copyright (C) 2000-2002 Philip Craig.
> >>   All Rights Reserved.
> >>
> >>   Runtime Environment -
> >>      OS Version: Microsoft Windows NT 5.1.2600 Service Pack 3
> >>     CLR Version: 2.0.50727.3634 ( Net 3.5 )
> >>
> >>   ProcessModel: Default    DomainUsage: Single
> >>   Execution Runtime: net-3.5
> >>   Run list: ./EmptyLibrary/Class1.cs
> >>   Unhandled Exception:
> >>   System.IndexOutOfRangeException: Index was outside the bounds of the
> >> array.
> >>      at NUnit.ConsoleRunner.ConsoleUi.Execute(ConsoleOptions options)
> >>      at NUnit.ConsoleRunner.Runner.Main(String[] args)
> >>
> >>   2) If /runlist path is incorrect, than 0 tests are run.  This is a
> >>   silent error that should also be handled by notifying users that no
> >>   such path exists.
> >>
> >> To manage notifications about this bug go to:
> >> https://bugs.launchpad.net/nunitv2/+bug/1057911/+subscriptions
> >>
> >
> > --
> > You received this bug notification because you are subscribed to NUnit
> > Extended Testing Platform.
> > https://bugs.launchpad.net/bugs/1057911
> >
> > Title:
> >   Trap incorrect input for nunit-console.exe options.
> >
> > To manage notifications about this bug go to:
> > https://bugs.launchpad.net/nunitv2/+bug/1057911/+subscriptions
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1057911
>
> Title:
>   Trap incorrect input for nunit-console.exe options.
>
> Status in NUnit V2 Test Framework:
>   Fix Committed
>
> Bug description:
>   nunit-console.exe should handle incorrect options gracefully.  As of
>   now, it either runs 0 tests or throws an unhandled exception.
>
>   1) Specifically, for the /runlist option, the following is thrown:
>
>   /cygdrive/c/Program\ Files/NUnit\ 2.6.1/bin/nunit-console.exe
> /runlist=./EmptyLibrary/Class1.cs ./NUnit/bin/Debug/NUnit.dll
>   NUnit-Console version 2.6.1.12217
>   Copyright (C) 2002-2012 Charlie Poole.
>   Copyright (C) 2002-2004 James W. Newkirk, Michael C. Two, Alexei A.
> Vorontsov.
>   Copyright (C) 2000-2002 Philip Craig.
>   All Rights Reserved.
>
>   Runtime Environment -
>      OS Version: Microsoft Windows NT 5.1.2600 Service Pack 3
>     CLR Version: 2.0.50727.3634 ( Net 3.5 )
>
>   ProcessModel: Default    DomainUsage: Single
>   Execution Runtime: net-3.5
>   Run list: ./EmptyLibrary/Class1.cs
>   Unhandled Exception:
>   System.IndexOutOfRangeException: Index was outside the bounds of the
> array.
>      at NUnit.ConsoleRunner.ConsoleUi.Execute(ConsoleOptions options)
>      at NUnit.ConsoleRunner.Runner.Main(String[] args)
>
>   2) If /runlist path is incorrect, than 0 tests are run.  This is a
>   silent error that should also be handled by notifying users that no
>   such path exists.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/nunitv2/+bug/1057911/+subscriptions
>

-- 
You received this bug notification because you are a member of NUnit
Developers, which is subscribed to NUnit V2.
https://bugs.launchpad.net/bugs/1057911

Title:
  Trap incorrect input for nunit-console.exe options.

Status in NUnit V2 Test Framework:
  Fix Committed

Bug description:
  nunit-console.exe should handle incorrect options gracefully.  As of
  now, it either runs 0 tests or throws an unhandled exception.

  1) Specifically, for the /runlist option, the following is thrown:

  /cygdrive/c/Program\ Files/NUnit\ 2.6.1/bin/nunit-console.exe /runlist=./EmptyLibrary/Class1.cs ./NUnit/bin/Debug/NUnit.dll
  NUnit-Console version 2.6.1.12217
  Copyright (C) 2002-2012 Charlie Poole.
  Copyright (C) 2002-2004 James W. Newkirk, Michael C. Two, Alexei A. Vorontsov.
  Copyright (C) 2000-2002 Philip Craig.
  All Rights Reserved.

  Runtime Environment -
     OS Version: Microsoft Windows NT 5.1.2600 Service Pack 3
    CLR Version: 2.0.50727.3634 ( Net 3.5 )

  ProcessModel: Default    DomainUsage: Single
  Execution Runtime: net-3.5
  Run list: ./EmptyLibrary/Class1.cs
  Unhandled Exception:
  System.IndexOutOfRangeException: Index was outside the bounds of the array.
     at NUnit.ConsoleRunner.ConsoleUi.Execute(ConsoleOptions options)
     at NUnit.ConsoleRunner.Runner.Main(String[] args)

  2) If /runlist path is incorrect, than 0 tests are run.  This is a
  silent error that should also be handled by notifying users that no
  such path exists.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nunitv2/+bug/1057911/+subscriptions


Follow ups

References