nunit-dev team mailing list archive

["Charlie Poole" <charlie@xxxxxxxxx>]

Hi All,

I experimented with sending a merge directive to the launchpad
merge address: merge@xxxxxxxxxxxxxxxxxx as Paul suggested.

The Core Developers team got the review request by default,
but I can see how to change it so all of you get it. I have
attached what was sent to us so everyone can see what it 
looks like.

I gather that the reviews can be made by email or on
the web site. I assume that we need to use email if we
want to actually discuss the fix. Paul, can you confirm?

I found a few drawbacks to this approach.

1. I had to try a number of times, making several changes to
locations.conf and bazaar.conf before I got it right. It's 
really easy once you have it set up correctly, but I don't
consider myself a slouch at such things and if it took me
a while it may totally stop some potential contributors.

2. You must sign your email with your GPG key. This is not
something most windows developers are set up to do so there
is a bit of a learning curve. Using Outlook, the only way I
could figure out to get my email signed was via the clipboard.
I believe that voting via email also requires a GPG key.

One thing we could try to do is give step by step instructions
about how to configure and how to use GPG. Some of this is 
already available, but it's not always clear how a Windows
user does it - and most of our potential developers are in
the world of windows.

The alternatives - I guess - to this approach are...

1. Just send a simple patch to the dev list and let somebody
else figure it out. This may be the best for the complete
newbie.

2. Push your branch to Launchpad and then propose it for 
merging via the web site. This requires that you have an
SSH client and key set up, which is yet another step, but
people may already have this from using Sourceforge or some
other site.

I'm looking for some ideas on this. How should we start out?
What direction should we try to take it?

Charlie

--- Begin Message ---

• To: <mp+10197@xxxxxxxxxxxxxxxxxx>
• From: "Charlie Poole" <charlie@xxxxxxxxx>
• Date: Fri, 14 Aug 2009 17:20:18 -0700
• Reply-to: <mp+10197@xxxxxxxxxxxxxxxxxx>
• Sender: <bounces@xxxxxxxxxxxxx>
• Thread-index: AcodPnYYBeRkW6vWSj2nr973h5Sb5g==

Charlie Poole has proposed merging lp:~charlie.poole/nunit-2.5/merge into lp:nunit-2.5.

Requested reviews:
    NUnit Core Developers (nunit-core)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Experiment: Sending merge directive via code.launchpad.net.
 
This is just a change to some comments.
 
Charlie
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32) - WinPT 1.4.1
Charset: UTF-8

iEYEARECAAYFAkqF/eIACgkQFNOQ5gKSruvRewCeK+ky9/5ZCLa+cA2DA6JnpYVn
qlwAn0CSeHJJtIajQMBzuaM/cjZpJxiC
=Wy1H
-----END PGP SIGNATURE-----

-- 
https://code.launchpad.net/~charlie.poole/nunit-2.5/merge/+merge/10197
You are the owner of lp:~charlie.poole/nunit-2.5/merge.

=== modified file 'src/NUnitFramework/framework/JoinTypeAttributes.cs'
--- src/NUnitFramework/framework/JoinTypeAttributes.cs	2009-04-18 21:11:18 +0000
+++ src/NUnitFramework/framework/JoinTypeAttributes.cs	2009-08-13 00:55:12 +0000
@@ -9,9 +9,11 @@
 namespace NUnit.Framework
 {
     /// <summary>
-    /// Marks a test to use a combinatorial join of any argument 
-    /// data provided. Since this is the default, the attribute is
-    /// not needed.
+    /// Marks a test to use a combinatorial join of any argument data 
+    /// provided. NUnit will create a test case for every combination of 
+    /// the arguments provided. This can result in a large number of test
+    /// cases and so should be used judiciously. This is the default join
+    /// type, so the attribute need not be used except as documentation.
     /// </summary>
     [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
     public class CombinatorialAttribute : PropertyAttribute
@@ -23,9 +25,10 @@
     }
 
     /// <summary>
-    /// Marks a test to use a combinatorial join of any argument 
-    /// data provided. Since this is the default, the attribute is
-    /// not needed.
+    /// Marks a test to use pairwise join of any argument data provided. 
+    /// NUnit will attempt too excercise every pair of argument values at 
+    /// least once, using as small a number of test cases as it can. With
+    /// only two arguments, this is the same as a combinatorial join.
     /// </summary>
     [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
     public class PairwiseAttribute : PropertyAttribute
@@ -37,9 +40,12 @@
     }
 
     /// <summary>
-    /// Marks a test to use a combinatorial join of any argument 
-    /// data provided. Since this is the default, the attribute is
-    /// not needed.
+    /// Marks a test to use a sequential join of any argument data
+    /// provided. NUnit will use arguements for each parameter in
+    /// sequence, generating test cases up to the largest number
+    /// of argument values provided and using null for any arguments
+    /// for which it runs out of values. Normally, this should be
+    /// used with the same number of arguments for each parameter.
     /// </summary>
     [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
     public class SequentialAttribute : PropertyAttribute

--- End Message ---