← Back to team overview

nuvola-player-devel team mailing list archive

Re: [Merge] lp:~mims-michael/nuvola-player/amazon-api2 into lp:nuvola-player

 

Review: Needs Fixing

First of all, thanks for relicensing of your work under 2-Clause BSD license. A few minor enhacements:

----8<----

74	+// this.extraFeatures();

[optional] You can remove this line.

----8<----

67	+ this.can_thumbs_up = false;
68	+ this.can_thumbs_down = false;
69	+ this.can_favorite = false;

These variables seem to be never used.
-- 
https://code.launchpad.net/~mims-michael/nuvola-player/amazon-api2/+merge/117292
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.


References