nuvola-player-devel team mailing list archive

[Jiří Janoušek <janousek.jiri@xxxxxxxxx>]

Review: Needs Fixing

Thanks, Michael, for your work. I'm sorry for a late reply, but I have time for Nuvola Player only during weekends.


=== modified file 'data/nuvolaplayer/services/rdio/integration.js'
8	- Copyright 2012 Stefan Lohmaier <stefan.lohmaier@xxxxxxxxxxxxxx>
9	+ Copyright 2012 Michael Mims <mims.michael@xxxxxxxxx>

Did you rewrite this script from scratch? If not, you cannot remove Stefan's copyright.

-----8<------

=== modified file 'data/nuvolaplayer/services/rdio/integration.js'
36	+ * client js side). See Nuvola bug #1049253.

Please use notation "LP:1049253".

-----8<------

=== modified file 'data/nuvolaplayer/services/rdio/metadata.conf'
178	version = 2
179	-version_minor = 4
180	-flash_plugin = no
181	+version_minor = 5

Increase version to 3.0 instead of 2.5.
-- 
https://code.launchpad.net/~mims-michael/nuvola-player/bugfix1049253/+merge/157699
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.