nuvola-player-devel team mailing list archive

[Jiří Janoušek <janousek.jiri@xxxxxxxxx>]

Review: Resubmit

> Implements:
> * Bug #1065602: Mouse back/forward button interaction
> * Bug #1212167: Back/forward buttons in UI (default off) for Google Play

Please resubmit each feature in a separate branch.

> For the latter a canNavigateBack/Forward JSApi property would be cool, but worked around this with navigation state emulation.

Could you create a ticket in bug tracker for this? https://bugs.launchpad.net/nuvola-player/+filebug

=== modified file 'data/nuvolaplayer/services/googleplay/integration.js'
29	+ var navigateBack = document.createElement('button');
40	+ var navigateFwd = document.createElement('button');

You could simplify code a bit with function Nuvola.makeElement(name, attributes, text):

var navigateBack = Nuvola.makeElement("button", {disabled: true}, "<");
navigateBack.className = ...
navigateBack.style ...
navigateBack.addEventListener ...

=== modified file 'src/nuvola/gui/mainwebview.vala'
119	+ this.button_release_event.connect(this.on_mouse_button_released);
134	+ this.go_back();
137	+ this.go_forward();

No need to use "this".

=== modified file 'src/nuvola/gui/servicesmanagerview.vala'
56	+ page.editable = false;

Good catch :-) Fixed in trunk.
-- 
https://code.launchpad.net/~mpdeimos/nuvola-player/nuvola-player/+merge/199922
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.