nuvola-player-devel team mailing list archive

[mpdeimos <mpdeimos@xxxxxxxxx>]

mpdeimos has proposed merging lp:~mpdeimos/nuvola-player/fix-service-prefs into lp:nuvola-player.

Requested reviews:
  Jiří Janoušek (fenryxo)

For more details, see:
https://code.launchpad.net/~mpdeimos/nuvola-player/fix-service-prefs/+merge/208965

I noticed some weird problem that the Service Preferences are not shown after merging your latest trunk with my google music navigation button integration. I'm not sure if this is just a problem on my installation (arch linux, 64 bit) or a global problem.

I've nailed the issue down to the commit "Removed debugging messages.". Here the line get_real_context(); has been removed. If I add this line back in, the service preferences load again.
It seems, however, that get_real_context(); has some side effects, so the fix is rather a hack imho.
-- 
https://code.launchpad.net/~mpdeimos/nuvola-player/fix-service-prefs/+merge/208965
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.

=== modified file 'src/nuvola/core/nuvola-framebridge.vala'
--- src/nuvola/core/nuvola-framebridge.vala	2014-02-11 17:24:46 +0000
+++ src/nuvola/core/nuvola-framebridge.vala	2014-03-02 13:51:46 +0000
@@ -142,6 +142,7 @@
 	
 	private unowned JS.Context get_context()
 	{
+		get_real_context();
 		return _context;
 	}