ocaml-maint team mailing list archive

[Jason Gross <1923272@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The patch file 0006-Disable-DT_TEXTREL-warnings-on-Linux-i386.patch is inadequate because it updates configure.ac without updating configure.  It should instead read something like
```
diff --git a/configure b/configure
index 74657d2..c1215b4 100755
--- a/configure
+++ b/configure
@@ -13899,6 +13899,18 @@ case $arch in #(
 esac ;;
 esac
 
+# Disable DT_TEXTREL warnings on Linux i386
+# See https://github.com/ocaml/ocaml/issues/9800
+
+case $host in #(
+  i?86-*-linux-*) :
+    common_cflags="-Wl,-z,notext $common_cflags"
+    mksharedlib="$mksharedlib -Wl,-z,notext"
+    mkmaindll="$mkmaindll -Wl,-z,notext" ;; #(
+  *) :
+     ;;
+esac
+
 # Assembler
 
 if test -n "$host_alias"; then :
diff --git a/configure.ac b/configure.ac
index aa5f26f..f43eaa4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1015,6 +1015,16 @@ AS_CASE([$arch],
        [common_cflags="-no-pie $common_cflags"],
     [])])
 
+# Disable DT_TEXTREL warnings on Linux i386
+# See https://github.com/ocaml/ocaml/issues/9800
+
+AS_CASE([$host],
+  [i?86-*-linux-*],
+    [common_cflags="-Wl,-z,notext $common_cflags"
+    mksharedlib="$mksharedlib -Wl,-z,notext"
+    mkmaindll="$mkmaindll -Wl,-z,notext"],
+  [])
+
 # Assembler
 
 AS_IF([test -n "$host_alias"], [toolpref="${host_alias}-"], [toolpref=""])
```

** Affects: ocaml (Ubuntu)
     Importance: Undecided
         Status: New

** Bug watch added: github.com/ocaml/ocaml/issues #9800
   https://github.com/ocaml/ocaml/issues/9800

-- 
You received this bug notification because you are a member of Debian
OCaml Maintainers, which is subscribed to ocaml in Ubuntu.
https://bugs.launchpad.net/bugs/1923272

Title:
  package is unbackportable to old i386 systems

Status in ocaml package in Ubuntu:
  New

Bug description:
  The patch file 0006-Disable-DT_TEXTREL-warnings-on-Linux-i386.patch is inadequate because it updates configure.ac without updating configure.  It should instead read something like
  ```
  diff --git a/configure b/configure
  index 74657d2..c1215b4 100755
  --- a/configure
  +++ b/configure
  @@ -13899,6 +13899,18 @@ case $arch in #(
   esac ;;
   esac
   
  +# Disable DT_TEXTREL warnings on Linux i386
  +# See https://github.com/ocaml/ocaml/issues/9800
  +
  +case $host in #(
  +  i?86-*-linux-*) :
  +    common_cflags="-Wl,-z,notext $common_cflags"
  +    mksharedlib="$mksharedlib -Wl,-z,notext"
  +    mkmaindll="$mkmaindll -Wl,-z,notext" ;; #(
  +  *) :
  +     ;;
  +esac
  +
   # Assembler
   
   if test -n "$host_alias"; then :
  diff --git a/configure.ac b/configure.ac
  index aa5f26f..f43eaa4 100644
  --- a/configure.ac
  +++ b/configure.ac
  @@ -1015,6 +1015,16 @@ AS_CASE([$arch],
          [common_cflags="-no-pie $common_cflags"],
       [])])
   
  +# Disable DT_TEXTREL warnings on Linux i386
  +# See https://github.com/ocaml/ocaml/issues/9800
  +
  +AS_CASE([$host],
  +  [i?86-*-linux-*],
  +    [common_cflags="-Wl,-z,notext $common_cflags"
  +    mksharedlib="$mksharedlib -Wl,-z,notext"
  +    mkmaindll="$mkmaindll -Wl,-z,notext"],
  +  [])
  +
   # Assembler
   
   AS_IF([test -n "$host_alias"], [toolpref="${host_alias}-"], [toolpref=""])
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ocaml/+bug/1923272/+subscriptions