← Back to team overview

openbravo-isv team mailing list archive

Re: New upstream package: openbravo-3

 

Hi Juan,

I just gave a quick look over the -3 package and have some
feedback/questions.  Much if not all of these will be things we already
covered before, but unfortunately, since it's a new package it need be done.

Before I begin I want to first thank you for continuing to maintain your
software for our various releases until they reach EOL, and also for doing
the detailed work on the copyright file which i know can be tedious.  It
makes my life easier and is much appreciated.  It has been a pleasure
working with you.  That being said, on to the not so fun stuff :-)

Looking at the lintian output:

* It seems you still embed jquery.js.  Any chance I can nudge you to using
the packaged version in our archive instead? (the same for dojo and dijit)

* There are many empty dirs in the package which IIRC goes back to your
method of copying files over from one place to another.  Is this correct?  I
would really like to discuss this again.

* We are trying to move init scripts to upstart scripts.  Would you be
opposed to doing this?

* There are numerous files in the package in both compressed and
uncompressed form.  One or the other should likely be removed.

* Your desktop file calls x-www-browser but should instead follow the
following format:

[Desktop Entry]
Encoding=UTF-8
Icon=/opt/kde3/share/apps/kdesktop/pics/ksslogo.png
Type=Link
URL=http://www.kde.org/

* Lintian overrides (debian/openbravo-3.lintian-overrides) should be added
for the remainder of items (and commented on as to why the override is being
added) in the lintian output that aren't actually problems. i.e.
dir-or-file-in-opt, script-not-executable, extra-license-file,
unknown-section, etc...

lintian -I, in the end, should return no output.  We didn't used to be this
strenuous, but the powers that be have asked me to ensure all new packages
are Lintian clean or overrides are provided.

Thanks again, and I look forward to hearing back from you soon.

-Brian


On Thu, Jan 13, 2011 at 8:01 AM, Juan Pablo Aroztegi <
juanpablo.aroztegi@xxxxxxxxxxxxx> wrote:

> Hi Brian,
>
> We've packaged and tested the new version of the package we talked about
> some weeks ago: openbravo-3. Both for Lucid and Maverick. From our side
> it's ready to be pushed into the Partner's repository. Would it be
> possible for you to review and push the package?
>
> Our plans are to maintain the openbravo-erp package for Karmic, Lucid
> and Maverick until their EOL. And this new openbravo-3 for Lucid,
> Maverick, Natty and the future Ubuntu releases.
>
>
> Thank you!
>
> Juan Pablo
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openbravo-isv
> Post to     : openbravo-isv@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openbravo-isv
> More help   : https://help.launchpad.net/ListHelp
>

References