opencog-dev team mailing list archive
-
opencog-dev team
-
Mailing list archive
-
Message #00487
Re: Remove support for TLB without map
2009/3/20 Linas Vepstas <linasvepstas@xxxxxxxxx>:
> 2009/3/20 Joel Pitt <joel.pitt@xxxxxxxxx>:
>> On Sat, Mar 21, 2009 at 3:13 AM, Linas Vepstas <linasvepstas@xxxxxxxxx> wrote:
>>>> (I've discover this is the source of some tests failing on buildbot
>>>> and for random people ...
> Perhaps you meant this:
> (NULL == TLB::getAtom(hand))
>
> Then that's OK, since it is exactly identical to
> TLB::IsInvalidHandle(hand)
>
> ... err, *should be identical*. After code review, I see
> that its not, and that is a bug. Should I fix it? Do you
> want to do this?
I fixed this, and now all test cases seem to pass, even
if there's no TLB.
I'll push that code shortly.
> I also see that TLB.h still has traces of "non-real atom"
> code in it. I presume its OK to remove this now?
I'm stubbing out the non-real-atom code now, we'll
see if this upsets the test cases or not. If the tests
pass, I'll check this code in.
--linas
References