opencompute-developers team mailing list archive

[Jeff Lane <jeffrey.lane@xxxxxxxxxxxxx>]

Jeff Lane has proposed merging lp:~bladernr/opencompute/ocp-fix-pkg-deps into lp:opencompute/checkbox.

Requested reviews:
  Open Compute Developers (opencompute-developers)
Related bugs:
  Bug #1233333 in The Open Compute Project: "test packages are not installed with ocp-checkbox"
  https://bugs.launchpad.net/opencompute/+bug/1233333

For more details, see:
https://code.launchpad.net/~bladernr/opencompute/ocp-fix-pkg-deps/+merge/188431

Promotes several test packages from suggests to recommends.  This is because they are not installed by default via apt-get when listed as suggests.  

Apt-get doesn't install "suggests" by default.  
-- 
https://code.launchpad.net/~bladernr/opencompute/ocp-fix-pkg-deps/+merge/188431
Your team Open Compute Developers is requested to review the proposed merge of lp:~bladernr/opencompute/ocp-fix-pkg-deps into lp:opencompute/checkbox.

=== modified file 'debian/changelog'
--- debian/changelog	2013-09-27 13:25:11 +0000
+++ debian/changelog	2013-09-30 19:22:32 +0000
@@ -12,6 +12,8 @@
   * Enabled bonnie++ tests after noting that bonnie++ is available via yum and
     apt. Added new disk io_stress jobs and disk_stress script to add disk
     testing via stressapptest.
+  * debian/control: promoted several packages from suggest to depends to ensure
+    they are installed along with checkbox-ocp (LP: #1233333)
 
  -- Jeff Marcom <jeff.marcom@xxxxxxxxxxxxx>  Mon, 23 Sep 2013 10:13:04 -0400
 

=== modified file 'debian/control'
--- debian/control	2013-09-25 15:48:13 +0000
+++ debian/control	2013-09-30 19:22:32 +0000
@@ -33,43 +33,44 @@
          ${misc:Depends},
          ${python3:Depends},
          ${shlibs:Depends}
-Recommends: dpkg (>= 1.13),
+Recommends: bonnie++,
+            cpu-checker,
+            curl,
+            dpkg (>= 1.13),
+            ethtool,
+            fwts,
+            git-core,
             gir1.2-gst-plugins-base-1.0,
             gir1.2-gstreamer-1.0,
             gstreamer1.0-plugins-good,
             gstreamer1.0-pulseaudio,
+            hdparm,
+            libaio1,
             libgstreamer1.0-0,
             lsb-release,
+            lshw,
+            mcelog,
             perl,
             pm-utils,
             python3-apt,
             python3-dbus,
             python3-gi
-Suggests: bonnie++,
-          bootchart,
+            smartmontools,
+            stress,
+            stressapptest,
+            sysstat,
+            wodim
+Suggests: bootchart,
           checkbox-ocp-cli | checkbox-ocp-gtk,
-          curl,
-          ethtool,
-          fwts,
-          git-core,
           glmark2,
           glmark2-es2,
-          hdparm,
-          libaio1,
-          lshw,
-          mcelog,
           mesa-utils,
           nmap,
           obexd-client,
           obexftp,
           render-bench,
-          smartmontools,
           sox,
-          stress,
-          stressapptest,
-          sysstat,
-          wmctrl,
-          wodim
+          wmctrl
 Description: System testing application
  This project provides an extensible interface for system testing. The
  results can then be sent to Launchpad.