opencompute-developers team mailing list archive

[Jeff Lane <jeffrey.lane@xxxxxxxxxxxxx>]

Review: Needs Fixing

Needs Fixing.  You need to do one more thing though... and I have a feeling you'll need to do this for all your merge requests.

You need to edit the file debian/changelog and follow the format you see contained inside.

Always put your changelog entries under your name and use a brief summary.  Do NOT change the version or date stamp info and always put your entries in the top most stanza of the changelog.

For example, you should change the change log to add something like this:

 [ Nelson Chu ]
 * data/whitelists/opencompute-certify-local.whitelist - Added new jobs to certification whitelist
 * jobs/TC-001-0002-Platform_Controller_Hub.txt.in - renamed file to match correct naming scheme
 * jobs/TC-003-0001-Hardware_Information.txt.in - added new jobs for Hardware Info test cases
 * scripts/bios_info - new script to gather bios data
 * scripts/disk_info - new script to gather disk information
 * scripts/raid_info - new script to get info on MegaRAID storage devices
 * jobs/local.txt.in - Added job to parse new hardware information job file

And please do likewise with all your other merge requests.
-- 
https://code.launchpad.net/~nelson-chu/opencompute/add-ocp-hardware-information-job/+merge/205905
Your team Open Compute Developers is subscribed to branch lp:opencompute/checkbox.