← Back to team overview

openerp-community-reviewer team mailing list archive

Common criteria to help reviewing

 

Hello, 

I propose using this part of the documentation : 
http://doc.openerp.com/v6.1/contribute/05_developing_modules.html#misc-guidelines 

to: 

    * have a check list when reviewing merge proposals 
    * redirect people to this link when a MP is rejected 
    * have a homogeneous policy among us to accept/reject MP 

I would add other things to these guidelines like : 

    * version number with 2 digits 
    * using the latest module manifest data (init_xml -> init, demo_xml -> demo) corresponding to the server version 
    * having a good description of the module, including documentation 
    * having screenshots if module provides views 


Feel free to comment. No hard feeling if we want to drop everything here. 

-- 
Maxime Chambreuil 
1-514-276-5468 #126 


Follow ups