openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Disapprove

Hi, Lorenzo, congrulations for your work.

Personally, I don't like too much these two things:

- Use invoice_webkit as dependency. It introduces a higher dependency (webkit) that is not needed by the funcionality itself. There are a lot of people that don't still use webkit. Maybe you can dump the result in a generic field without format and in that special field (if exists). Altough my second comment is...
- Load data into a text field. Why don't load it in a many2many field like other references (order_lines and so on)?

But I don't want to go against the current, so if other people consider this valid, go ahead.
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_invoice_production_lot_7/+merge/181747
Your team Account Core Editors is subscribed to branch lp:account-invoicing.