openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

> Thanks for the proposal, little things to fix:
> 
> Line 18: remove the print message
> Line 25: I wonder if raising an error here is the way to go. I mean, If we do
> need another constraint based on the reconcile checkbook, then why not making
> a second constraint for that ?
> 
> IMO, We should add a constraint for the "_check_reconcile_true_account" and
> not include it in the "_check_same_account" one.
> 
> Regards,

That's substantially the comment I made on the OPW's patch: https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-597045-rmu/+merge/187180
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/lp1215897/+merge/187192
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.