openerp-community-reviewer team mailing list archive

["Yannick Vaucher @ Camptocamp" <yannick.vaucher@xxxxxxxxxxxxxx>]

Review: Needs Fixing code, no test

Nitpicking

l35: one space to be removed
l434 and l435 aren't aligned as well
l436: missing #

Or

What about removing those trailing and bothering # as you did in sale_payment_method/sale.py?
:%s/\s\+#$//

in xml files name of the module is named in header comment shouldn't we change it to new name sale_payment_method for this splitted part?

l488 misleader name for view this one is in sale_payment_method and not in sale_quick_payment

l600 + l1222
import of decimal_precision should be 
import openerp.addons.decimal_precision as dp


in pay_sale_order.xml there is another 
            <field name="type">form</field>
you can remove as you did it in edited xml files

-- 
https://code.launchpad.net/~extra-addons-commiter/e-commerce-addons/7.0-sale-method/+merge/155916
Your team E-Commerce Addons Core Editors is requested to review the proposed merge of lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-method into lp:e-commerce-addons.