openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~openerp-community/geospatial-addons/7.0 into lp:geospatial-addons/7.0

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>
Date: Fri, 27 Sep 2013 11:29:09 -0000
In-reply-to: <20130920163927.7735.92042.launchpad@ackee.canonical.com>
Reply-to: mp+186841@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Hello, 

Thanks for your MP. Fixing view can be quite a pain…

I have fixed some code in geo sale module to avoid installation error.


That said I have also set module to be uninstallable.

The map view (outside of form) is broken there is some oddities in edit mode.
There is no test at that time (All what is needed is available but not in the correct form) and other strange behavior to be fixed with attrs in layers view.

At that time addon does not reach community standard to be merges as is. So having addons uninstallable will allows me to merge you work as a progression in the port of the modules.

If you agree with that i will approve your MP.

I know it is quite a huge work to port this module. Thanks for the work done.

Regards

Nicolas


-- 
https://code.launchpad.net/~openerp-community/geospatial-addons/7.0/+merge/186841
Your team Geospatial Addons Core Editors is subscribed to branch lp:geospatial-addons/7.0.