openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~parthiv-patel/web-addons/web-addons into lp:web-addons

To: Parthiv Patel <parthiv.launchpad@xxxxxxxxxxxxxxxxxx>
From: Nhomar - Vauxoo <nhomar@xxxxxxxxx>
Date: Sat, 28 Sep 2013 03:28:31 -0000
In-reply-to: <20130813052629.16292.32063.launchpad@ackee.canonical.com>
Reply-to: mp+179846@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I approve this MP.

I tested and all work as expected.

Some few comments but dont block my approval, i think can be better as blueprints or for V2. 

1.-
I only think (but it is not mandatory) the css stuff can be a little better, for example the "Upload" Button can be like the original one (it is more elegant), I can do it before merge, but your branch is not ~openerp-community ;-).

2.-
The text "Change a Photo" Should say "Change Image".

3.- It is a question, shouldn't be more elegant have all buttons as mouse and not take this part of the screen?

Really THANKS a lot for your effort, I can do by myself this change if ypu dont have the time friend, just tell me.

Regards.


-- 
https://code.launchpad.net/~parthiv-patel/web-addons/web-addons/+merge/179846
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.