openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Hi, Joaquin, don't worry. It's only for keeping history.

Let me make some final comments:

- It is not necessary to instantiate wizard_renumber.
- "_process", "get_id" and "get_sequence_id_for_fiscalyear_id" seems to be legacy code included before because ir.sequence doesn't have methods to handle for example different dates from current or to detect some others fiscal year sequences, but I assume that this has changed on v7 (or even previously). Can you investigate further to try to avoid these methods and call ir.sequence methods?
- If the methods cannot be avoided, please remove cr.commit() line, because method code must never call it. Also the try sentence intrigues me why it is there...
- Please change order or "Renumber" and "Cancel" buttons to accomodate normal OpenERP standards.

Sorry for being so touchy, but it's for making the best module possible.

Keep going with your great work!

Regards.
-- 
https://code.launchpad.net/~joaquing-pedrosa/account-financial-tools/account-financial-tools/+merge/187936
Your team OpenERP Community Reviewer is subscribed to branch lp:account-financial-tools.