openerp-community-reviewer team mailing list archive

[Nicolas Bessi - Camptocamp <nicolas.bessi@xxxxxxxxxxxxxx>]

Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/ocb-addons/7.0-fix-1238508-nbi into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1238508 in OpenERP Addons: "Confirmation of chained internal package does not propagate availability"
  https://bugs.launchpad.net/openobject-addons/+bug/1238508

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1238508-nbi/+merge/190558

Fix bug 1238508
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1238508-nbi/+merge/190558
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~camptocamp/ocb-addons/7.0-fix-1238508-nbi into lp:ocb-addons.

=== modified file 'stock/stock.py'
--- stock/stock.py	2013-10-04 12:22:57 +0000
+++ stock/stock.py	2013-10-11 09:05:15 +0000
@@ -2383,7 +2383,6 @@
                 todo.append(move.id)
         if todo:
             self.action_confirm(cr, uid, todo, context=context)
-            todo = []
 
         for move in self.browse(cr, uid, ids, context=context):
             if move.state in ['done','cancel']:
@@ -2407,12 +2406,11 @@
 
             self._create_product_valuation_moves(cr, uid, move, context=context)
             if move.state not in ('confirmed','done','assigned'):
-                todo.append(move.id)
-
-        if todo:
-            self.action_confirm(cr, uid, todo, context=context)
-
-        self.write(cr, uid, move_ids, {'state': 'done', 'date': time.strftime(DEFAULT_SERVER_DATETIME_FORMAT)}, context=context)
+                self.action_confirm(cr, uid, [move.id], context=context)
+            self.write(cr, uid, [move.id], 
+                       {'state': 'done', 
+                       'date': time.strftime(DEFAULT_SERVER_DATETIME_FORMAT)}, 
+                       context=context)
         for id in move_ids:
              wf_service.trg_trigger(uid, 'stock.move', id, cr)