openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing code review and test

Hi, Romain, thank you for bringing this module to community repositories. I have tested the module and works properly, but there are some improvements that you can make according community guidelines:

- Make it PEP8 compliance. You can use flake8 tool to check this.
- Remove commented lines in product.py.
- In __init__.py, use form "from . import product".
- Remove companies references (Opentia and so on) on module description (put it for example as a comment).
- Add a new key 'contributores' in __openerp__.py to reflect people or companies that has contributed on the module. I suppose Julius Network Solutions is a contributor, not an author. If you have made any kind of adaptation, you can put also in this section.
- Remove .mo file on i18n.
- Add .pot template file to allow translations.

Regards.
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add_and_update_stock_filter_none_zero_qty_addon/+merge/189835
Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows/7.0.