← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1220732 into lp:ocb-addons

 

Thank you for taking my suggestion into account from the earlier proposal to explicitely select the target moves!

Looking at the proposal on upstream (https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-opw-597492-pna/+merge/187151) I see a couple of minor differences, which have to be resolved to prevent conflicts.

- This branch adds the field definition and default value for 'target move', but this is superfluous as the field already exists on the inherited model account.report.common.
- The upstream branch checks for context is None before copying in l.49
- Whitespace in l.68..71
- Adds target move in the 'based on' representation on the report.

Seems to me you can adopt all differences from the upstream branch.



-- 
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1220732/+merge/183911
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.