← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~camptocamp/margin-analysis/7.0-port-product_standard_margin-yvr into lp:margin-analysis

 

Review: Needs Fixing code review and test

Hi, Yannick,

Thank you for the module!

I have tried it and I can't see the fields of this module. I have seen that the view definition refers to "price_margin", but that field is used for product variant. I have activated this option though, but still no luck. Can you please take a look at this?

There's also another minor corrections to take care of:

- PEP8 compliance.
- Include pot file.

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_standard_margin-yvr/+merge/190349
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.


References