← Back to team overview

openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons

To: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Mon, 14 Oct 2013 18:27:07 -0000
In-reply-to: <20131003145724.27975.19130.launchpad@ackee.canonical.com>
Reply-to: mp+189107@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Thanks, great work! I think you can save some lines by calling product_product._compute_price() but I am guessing that either Ronald or you didn't think it was a good idea to call a private method which is fair enough.

-- 
https://code.launchpad.net/~therp-nl/ocb-addons/lp754339/+merge/189107
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.

References

[Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons
From: Holger Brunn (Therp), 2013-10-03