openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~lin-yu/account-invoicing/add_account_invoce_line into lp:account-invoicing

To: LIN Yu <lin.yu@xxxxxxxxxxxxxx>
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Thu, 17 Oct 2013 12:00:44 -0000
In-reply-to: <20130828021428.15024.79646.launchpad@ackee.canonical.com>
Reply-to: mp+182531@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove code review, no tests

Dear Lin,


Thank you for this contribs ! At first glance, the view in "Reporting -> Accounting -> Invoicing" or something like this seems to provide that feature or am I wrong ?

I rather prefer to have a module that extend this feature then, for that reason i disapprove the MP.

If you have any good reason not to do it there, please let us knoe !

Regards,

Joël
-- 
https://code.launchpad.net/~lin-yu/account-invoicing/add_account_invoce_line/+merge/182531
Your team Account Core Editors is subscribed to branch lp:account-invoicing.