← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr into lp:margin-analysis

 

About OpenERP "standard" of former code we also have import with bad namespace, use of class alias and useless class instanciations.

In OpenERP coding guidelines nothing is clearly said about XML indentation:
https://doc.openerp.com/7.0/contribute/15_guidelines/
As you said, this is defacto

Nevertheless, my opinion is that we shouldn't say "this is a standard" if there are no obvious reasons beside it.

So what will be the community standard we will decide and why?


By the way, readability counts
(Does it also counts on code review in lp?)
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr/+merge/190350
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.


References