← Back to team overview

openerp-community-reviewer team mailing list archive

Re: lp:~alejandrosantana/ocb-server/6.1-fix-dbfilter-ignored-in-config-file into lp:ocb-server/6.1

 

Review: Approve

Checked the code, and learned that as command line options are processed after the config file is read, having a 'default' parameter masks a value for the same key in the config file. The custom parameter 'my_default' is used as a default value for when the key does not occur in neither the config file nor the command line parameters. So this change fixes the problem properly.

-- 
https://code.launchpad.net/~alejandrosantana/ocb-server/6.1-fix-dbfilter-ignored-in-config-file/+merge/192442
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server/6.1.


References