openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #00781
lp:~yann-papouin/ocb-addons/6.1-bug-1222733-address-create-wpartner into lp:ocb-addons/6.1
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-1222733-address-create-wpartner into lp:ocb-addons/6.1.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1222733 in OpenERP Community Backports (Addons): "[v6.1]When creating an address in an official module, the partner is not set by default"
https://bugs.launchpad.net/ocb-addons/+bug/1222733
For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1222733-address-create-wpartner/+merge/192660
Automatically derived from https://code.launchpad.net/~yann-papouin/openobject-addons/6.1-bug-1222733-address-create-wpartner for https://code.launchpad.net/~openerp/openobject-addons/6.1. Below is a copy of the original description.
Basically, always add a context [1] to "partner_address_id" like fields and disable [2] quick create to allow the user to create firstname/surname of the contact.
[1] context="{'default_partner_id':partner_id}"
[2] options='{"quick_create": false}'
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1222733-address-create-wpartner/+merge/192660
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~yann-papouin/ocb-addons/6.1-bug-1222733-address-create-wpartner into lp:ocb-addons/6.1.
=== modified file 'crm/crm_lead_view.xml'
--- crm/crm_lead_view.xml 2012-11-20 11:39:58 +0000
+++ crm/crm_lead_view.xml 2013-10-25 09:52:15 +0000
@@ -483,6 +483,8 @@
<field name="partner_address_id"
string="Contact"
on_change="onchange_partner_address_id(partner_address_id, email_from)"
+ options='{"quick_create": false}'
+ context="{'default_partner_id':partner_id}"
colspan="1" />
<group col="3" colspan="2">
<field name="email_from" string="Email" />
=== modified file 'crm/crm_meeting_view.xml'
--- crm/crm_meeting_view.xml 2012-01-31 13:36:57 +0000
+++ crm/crm_meeting_view.xml 2013-10-25 09:52:15 +0000
@@ -62,7 +62,9 @@
on_change="onchange_partner_id(partner_id)" />
<field name="partner_address_id"
string="Contact"
- on_change="onchange_partner_address_id(partner_address_id, email_from)" />
+ on_change="onchange_partner_address_id(partner_address_id, email_from)"
+ options='{"quick_create": false}'
+ context="{'default_partner_id':partner_id}" />
<field name="email_from"/>
</group><group col="2" colspan="2">
<separator colspan="2" string="Visibility"/>
=== modified file 'crm/crm_phonecall_view.xml'
--- crm/crm_phonecall_view.xml 2011-12-21 13:10:28 +0000
+++ crm/crm_phonecall_view.xml 2013-10-25 09:52:15 +0000
@@ -92,7 +92,9 @@
groups="base.group_partner_manager"/>
<newline/>
<field name="partner_address_id"
- on_change="onchange_partner_address_id(partner_address_id)" />
+ on_change="onchange_partner_address_id(partner_address_id)"
+ options='{"quick_create": false}'
+ context="{'default_partner_id':partner_id}" />
<newline/>
<field name="partner_mobile" />
</group>
=== modified file 'crm_claim/crm_claim_view.xml'
--- crm_claim/crm_claim_view.xml 2012-01-31 13:36:57 +0000
+++ crm_claim/crm_claim_view.xml 2013-10-25 09:52:15 +0000
@@ -91,7 +91,9 @@
<field name="partner_id" string="Partner"
on_change="onchange_partner_id(partner_id)" />
<field name="partner_address_id" string="Contact"
- on_change="onchange_partner_address_id(partner_address_id, email_from)" />
+ on_change="onchange_partner_address_id(partner_address_id, email_from)"
+ options='{"quick_create": false}'
+ context="{'default_partner_id':partner_id}" />
<field name="partner_phone"/>
<field name="email_from" widget="email"/>
</group>
=== modified file 'crm_fundraising/crm_fundraising_view.xml'
--- crm_fundraising/crm_fundraising_view.xml 2011-12-19 16:54:40 +0000
+++ crm_fundraising/crm_fundraising_view.xml 2013-10-25 09:52:15 +0000
@@ -97,6 +97,8 @@
<field name="partner_address_id"
string="Contact"
on_change="onchange_partner_address_id(partner_address_id, email_from)"
+ options='{"quick_create": false}'
+ context="{'default_partner_id':partner_id}"
colspan="1" />
<field name="email_from" colspan="2"/>
</group>
=== modified file 'crm_helpdesk/crm_helpdesk_view.xml'
--- crm_helpdesk/crm_helpdesk_view.xml 2011-12-19 16:54:40 +0000
+++ crm_helpdesk/crm_helpdesk_view.xml 2013-10-25 09:52:15 +0000
@@ -49,7 +49,8 @@
select="1" />
<field name="partner_address_id" colspan="2"
on_change="onchange_partner_address_id(partner_address_id, email_from)"
- />
+ options='{"quick_create": false}'
+ context="{'default_partner_id':partner_id}" />
<newline/>
<field name="email_from" colspan="2"/>
<button name="remind_partner"
=== modified file 'hr_recruitment/hr_recruitment_view.xml'
--- hr_recruitment/hr_recruitment_view.xml 2011-12-21 13:10:28 +0000
+++ hr_recruitment/hr_recruitment_view.xml 2013-10-25 09:52:15 +0000
@@ -104,7 +104,7 @@
name="%(action_hr_recruitment_partner_create)d"
icon="gtk-index" type="action" attrs="{'readonly':[('partner_id','!=',False)]}" groups="base.group_partner_manager"/>
<newline/>
- <field name="partner_address_id" on_change="onchange_partner_address_id(partner_address_id, email_from)" colspan="3"/>
+ <field name="partner_address_id" on_change="onchange_partner_address_id(partner_address_id, email_from)" options='{"quick_create": false}' context="{'default_partner_id':partner_id}" colspan="3"/>
<field name="email_from" colspan="3"/>
<field name="partner_phone" colspan="3"/>
<field name="partner_mobile" colspan="3"/>
=== modified file 'project/project_view.xml'
--- project/project_view.xml 2012-03-12 10:20:01 +0000
+++ project/project_view.xml 2013-10-25 09:52:15 +0000
@@ -68,8 +68,8 @@
</field>
</page>
<page string="Billing" groups="account.group_account_invoice">
- <field colspan="4" name="partner_id" on_change="onchange_partner_id(partner_id)" select="1" string="Customer"/>
- <field domain="[('partner_id','=',partner_id)]" name="contact_id" string="Contact Address"/>
+ <field name="partner_id" on_change="onchange_partner_id(partner_id)" select="1" string="Customer" colspan="4" />
+ <field name="contact_id" string="Contact Address" domain="[('partner_id','=',partner_id)]" options='{"quick_create": false}' context="{'default_partner_id':partner_id}" />
<field name="warn_customer"/>
<field name="currency_id" select="1" groups="base.group_multi_company" required="1"/>
<newline/>
=== modified file 'project_issue/project_issue_view.xml'
--- project_issue/project_issue_view.xml 2012-03-12 11:29:31 +0000
+++ project_issue/project_issue_view.xml 2013-10-25 09:52:15 +0000
@@ -68,7 +68,7 @@
<group col="2" colspan="2">
<separator colspan="2" string="Contact Information"/>
<field name="partner_id" on_change="onchange_partner_id(partner_id, email_from)"/>
- <field name="partner_address_id" string="Contact" on_change="onchange_partner_address_id(partner_address_id, email_from)"/>
+ <field name="partner_address_id" string="Contact" on_change="onchange_partner_address_id(partner_address_id, email_from)" options='{"quick_create": false}' context="{'default_partner_id':partner_id}" />
<field name="email_from"/>
</group>
<group col="3" colspan="2">
=== modified file 'purchase/purchase_view.xml'
--- purchase/purchase_view.xml 2012-10-23 07:56:26 +0000
+++ purchase/purchase_view.xml 2013-10-25 09:52:15 +0000
@@ -173,7 +173,7 @@
<notebook colspan="4">
<page string="Purchase Order">
<field name="partner_id" on_change="onchange_partner_id(partner_id)" domain="[('supplier', '=', True)]" context="{'search_default_supplier':1,'default_supplier':1,'default_customer':0}" options='{"quick_create": false}'/>
- <field name="partner_address_id" options='{"quick_create": false}'/>
+ <field name="partner_address_id" options='{"quick_create": false}' context="{'default_partner_id':partner_id}"/>
<field domain="[('type','=','purchase')]" name="pricelist_id" groups="base.group_extended"/>
<field name="origin" groups="base.group_extended"/>
<newline/>
=== modified file 'purchase_requisition/wizard/purchase_requisition_partner_view.xml'
--- purchase_requisition/wizard/purchase_requisition_partner_view.xml 2011-01-14 00:11:01 +0000
+++ purchase_requisition/wizard/purchase_requisition_partner_view.xml 2013-10-25 09:52:15 +0000
@@ -9,7 +9,7 @@
<form string="Purchase Requisition">
<group colspan="2" col="2">
<field name="partner_id" on_change="onchange_partner_id(partner_id)"/>
- <field domain="[('partner_id','=',partner_id)]" name="partner_address_id"/>
+ <field name="partner_address_id" domain="[('partner_id','=',partner_id)]" options='{"quick_create": false}' context="{'default_partner_id':partner_id}" />
<separator string="" colspan="4" />
<button icon="gtk-cancel" special="cancel" string="_Cancel"/>
<button icon="gtk-ok" name="create_order" string="Create Quotation" type="object"/>
=== modified file 'sale/sale_view.xml'
--- sale/sale_view.xml 2013-01-02 11:50:01 +0000
+++ sale/sale_view.xml 2013-10-25 09:52:15 +0000
@@ -116,9 +116,9 @@
<notebook colspan="5">
<page string="Sales Order">
<field name="partner_id" options='{"quick_create": false}' on_change="onchange_partner_id(partner_id)" domain="[('customer','=',True)]" context="{'search_default_customer':1}" required="1"/>
- <field domain="[('partner_id','=',partner_id)]" name="partner_order_id" on_change="onchange_partner_order_id(partner_order_id, partner_invoice_id, partner_shipping_id)" options='{"quick_create": false}'/>
- <field domain="[('partner_id','=',partner_id)]" name="partner_invoice_id" groups="base.group_extended" options='{"quick_create": false}'/>
- <field domain="[('partner_id','=',partner_id)]" name="partner_shipping_id" groups="base.group_extended" options='{"quick_create": false}'/>
+ <field domain="[('partner_id','=',partner_id)]" name="partner_order_id" on_change="onchange_partner_order_id(partner_order_id, partner_invoice_id, partner_shipping_id)" options='{"quick_create": false}' context="{'default_partner_id':partner_id}"/>
+ <field domain="[('partner_id','=',partner_id)]" name="partner_invoice_id" groups="base.group_extended" options='{"quick_create": false}' context="{'default_partner_id':partner_id}"/>
+ <field domain="[('partner_id','=',partner_id)]" name="partner_shipping_id" groups="base.group_extended" options='{"quick_create": false}' context="{'default_partner_id':partner_id}"/>
<field domain="[('type','=','sale')]" name="pricelist_id" groups="base.group_extended" on_change="onchange_pricelist_id(pricelist_id,order_line)"/>
<field name="project_id" context="{'partner_id':partner_id, 'contact_id':partner_order_id, 'pricelist_id':pricelist_id, 'default_name':name}" groups="analytic.group_analytic_accounting" domain="[('type','<>','view'), ('company_id', '=', company_id), ('parent_id', '!=', False)]"/>
<newline/>
Follow ups
