← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~the-clone-master/oemedical/oemedical into lp:oemedical

 

Review: Approve code review, no test

Hi, Mario, thank you very much for your contribution. New import format is welcome, but why are you putting "import openerp" statement? This is not needed.

You can also improve another coding conventions, like replace osv.Model (or osv.osv if any) by orm.Model, put in __init__.py "from . import xxx" for local imports, and also PEP8 is desirable.

Regards.
-- 
https://code.launchpad.net/~the-clone-master/oemedical/oemedical/+merge/193037
Your team OEmedical Commiter is subscribed to branch lp:oemedical.


Follow ups

References