openerp-community-reviewer team mailing list archive

["Vincent Renaville@camptocamp" <vincent.renaville@xxxxxxxxxxxxxx>]

Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/partner-contact-management/partner_firstname_vre_view_change into lp:partner-contact-management.

Requested reviews:
  Partner and Contact Core Editors (partner-contact-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_view_change/+merge/193074

Hello,

This patch clean the contact view of partner for firstname / lastname fields.


Vincent

-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_view_change/+merge/193074
Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~camptocamp/partner-contact-management/partner_firstname_vre_view_change into lp:partner-contact-management.

=== modified file 'partner_firstname/partner_view.xml'
--- partner_firstname/partner_view.xml	2013-04-30 08:10:08 +0000
+++ partner_firstname/partner_view.xml	2013-10-29 15:50:38 +0000
@@ -7,7 +7,9 @@
       <field name="arch" type="xml">
         <field name="category_id" position="before">
           <group>
+			<label for="lastname" string="Lastname"/>
             <field name="lastname"/>
+			<label for="firstname" string="Firstname"/>
             <field name="firstname"/>
           </group>
         </field>
@@ -21,15 +23,28 @@
       <field name="arch" type="xml">
         <field name="category_id" position="before">
           <group>
+          	<div>
+			<label for="lastname" string="Lastname"/>
             <field name="lastname"/>
+			<label for="firstname" string="Firstname"/>
             <field name="firstname"/>
+            </div>
           </group>
         </field>
         <!-- Add firstname and last name in inner contact form of child_ids -->
-        <xpath expr="//form[@string='Contact']/sheet/div/h1/field[@name='name']" position="after">
+        <xpath expr="//form[@string='Contact']/sheet/div" position="after">
+        	<group>
+        	<div>
+			<label for="lastname" string="Lastname"/>
             <field name="lastname"/>
+			<label for="firstname" string="Firstname"/>
             <field name="firstname"/>
+            </div>
+            </group>
         </xpath>
+        <xpath expr="//form[@string='Contact']/sheet/div/h1" position="before">
+            <field name="is_company" on_change="onchange_type(is_company)" class="oe_inline"/> <label for="is_company" string="Is a Company?"/>)
+		</xpath>
       </field>
     </record>