openerp-community-reviewer team mailing list archive

["Luc De Meyer \(Noviat\)" <luc.demeyer@xxxxxxxxx>]

Branch https://code.launchpad.net/~luc-demeyer/server-env-tools/7.0-report_xls has been updated with technical recommendations.

Regards,
Luc

-----Original Message-----
From: bounces@xxxxxxxxxxxxx [mailto:bounces@xxxxxxxxxxxxx] On Behalf Of Alexandre Fayolle - camptocamp
Sent: donderdag 24 oktober 2013 10:13
To: mp+192242@xxxxxxxxxxxxxxxxxx
Subject: Re: [Merge] lp:~luc-demeyer/server-env-tools/7.0-report_xls into lp:server-env-tools

Review: Needs Fixing code review, no test

Could you take the time to bring this to the 7.0 community addons coding conventions. This includes:

* not using the shortcut imports (things in the openerp namespace need to be imported from openerp)
* using the from . import xxx for relative imports (typically in __init__.py files)
* using orm.Model and orm.TransientModel as base class rather than osv.osv and osv.osv_memory
* not instanciating the model classes
* following PEP8 for spacing, line wrapping, etc. 

Nice to have would be a couple of automated tests exercising the code. 
-- 
https://code.launchpad.net/~luc-demeyer/server-env-tools/7.0-report_xls/+merge/192242
You are the owner of lp:~luc-demeyer/server-env-tools/7.0-report_xls.


https://code.launchpad.net/~luc-demeyer/server-env-tools/7.0-report_xls/+merge/192242
Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools.