openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons

To: "Holger Brunn \(Therp\)" <hbrunn@xxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Sat, 02 Nov 2013 14:05:41 -0000
In-reply-to: <20131021075926.32224.48854.launchpad@ackee.canonical.com>
Reply-to: mp+189107@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Christophe, thank you for your swift actions! I see that _compute_price is called on a uom browse record instead of on a model object, which implicitely passes cr, uid, [res_id] and context. The first three arguments are passed explicitely too in line 106, while the method does not take a context argument at all.
 
Sorry I missed this in my review.

-- 
https://code.launchpad.net/~therp-nl/ocb-addons/lp754339/+merge/189107
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons.

References

[Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons
From: Holger Brunn (Therp), 2013-10-21