openerp-community-reviewer team mailing list archive

["Guewen Baconnier @ Camptocamp" <guewen.baconnier@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Hi,

Thanks for the proposal.

While I understand the logic you want to change I don't understand what problem you want to fix (I could maybe guess but I'm not sure).
The code you propose was the same and we had to replace it by the more convoluted version that you want to replace.

This method is used by the partner reports (computation of the initial balance) and we need to find the opening period of the "first year _with_ accounting entries". We want the balance of the very first opening period. If we just search by date, we may find an opening period on a year which has not been used for the accounting => balance would be mistakenly 0.

-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch lp:account-financial-report.