openerp-community-reviewer team mailing list archive

[Ronald Portier <ronald@xxxxxxxxxx>]

I also vote for 2 spaces.

Also please: if there is more then one attribute, have each attribute on a new line.

(Unfortunately OpenERP will break if you spread attributes over multiple lines, even where this would be perfectly logical, as with long domain expressions).

Having each attribute on a new line will make changes much more "diff friendly". if you change one attribute, instead of having to scan a very long line where exactly anything changed, this will be immediately obvious.

-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr/+merge/190350
Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis.