← Back to team overview

openerp-community-reviewer team mailing list archive

lp:~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults into lp:ocb-addons

 

Stefan Rijnhart (Therp) has proposed merging lp:~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1249600 in OpenERP Community Backports (Addons): "[OCB] Default partner email settings frustrate common flow"
  https://bugs.launchpad.net/ocb-addons/+bug/1249600

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults/+merge/194621
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults/+merge/194621
Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults into lp:ocb-addons.
=== modified file 'email_template/res_partner.py'
--- email_template/res_partner.py	2013-08-15 07:54:23 +0000
+++ email_template/res_partner.py	2013-11-09 13:52:03 +0000
@@ -34,7 +34,7 @@
     }
 
     _defaults = {
-        'opt_out': True,
+        'opt_out': False,
     }
 
 # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== modified file 'mail/res_partner.py'
--- mail/res_partner.py	2013-08-15 07:54:23 +0000
+++ mail/res_partner.py	2013-11-09 13:52:03 +0000
@@ -43,7 +43,7 @@
     }
 
     _defaults = {
-        'notification_email_send': lambda *args: 'none'
+        'notification_email_send': lambda *args: 'comment'
     }
 
     def message_get_suggested_recipients(self, cr, uid, ids, context=None):


Follow ups