openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~jean-lelievre/purchase-report/product_inventory_warning into lp:purchase-report

To: Jean LELIEVRE ElicoCorp <jean.lelievre@xxxxxxxxxxxxxx>
From: "Maxime Chambreuil \(http://www.savoirfairelinux.com\)" <maxime.chambreuil@xxxxxxxxxxxxxxxxxxxx>
Date: Sun, 10 Nov 2013 16:07:59 -0000
In-reply-to: <20130826085537.21700.60718.launchpad@ackee.canonical.com>
Reply-to: mp+182057@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing code review

Hello Jean,

Based on the description of the MP and the module, I would say that the feature is already in OpenERP (OpenERP already provides the qty of product). I think you should add some documentation to explain what OpenERP doesn't do, what your module brings and how to use it.

Please fix PEP8 issues and add the pot file.

I have never seen a module with so much SQL queries. I would be interested to know how it scales.

Otherwise LGTM.

Thanks for your work!
-- 
https://code.launchpad.net/~jean-lelievre/purchase-report/product_inventory_warning/+merge/182057
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.