openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #01220
Re: [Merge] lp:~s-ferket/oemedical/oemedical into lp:oemedical
Review: Needs Fixing code review
Hi,
Can you respect the pep8 please? You can use flake8 to check that.
at l.18: the "context" argument should have a mutable type as default value, you have to replace "context={}" by "context=None".
at l.51: 'method=True' has been deprecated in OpenERP 7.0.
patient_data.dob is passed 2 times to "compute_age_from_dates": one argument can be removed.
Thanks
--
https://code.launchpad.net/~s-ferket/oemedical/oemedical/+merge/184581
Your team OEmedical Commiter is subscribed to branch lp:oemedical.