openerp-community-reviewer team mailing list archive

[Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>]

Review: Needs Fixing

Hi, Thomas, sorry for bothering you again, but there is other things you can improve:

- On __init__.py, instead of "import partner", please put "from . import partner".
- On __openerp__.py, you put on description that the sequence is for customer, but the code what makes is assign a sequence to customers, suppliers, users, and any partner that don't have a parent_id assigned. You should do two things: 
   a) change description to put that the sequence is assigned to customers and supppliers.
   b) change _needsRef code to restrict the result to only customers and suppliers.
- When you call _needsRef method, you can use keyword arguments for better coding practises:

self._needsRef(cr, uid, id, None, context)

change by

self._needsRef(cr, uid, id=id, context=context)

Thank you for your effort.

Regards.
-- 
https://code.launchpad.net/~initos.com/partner-contact-management/7.0/+merge/195066
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.