openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #01397
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
Review: Needs Fixing code review, no test
Hi, Markus,
Thank you very much for the new MP.
Some things seeing the code (not functional review yet):
- Lines inside for of _append_childs have an incorrect indentation.
- You should make PEP8 compliance according community guides. You can use flake8 tool to check it on .py files.
--
https://code.launchpad.net/~initos.com/account-analytic/7.0/+merge/195362
Your team Account Core Editors is subscribed to branch lp:account-analytic.
Follow ups
-
[Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: noreply, 2014-04-18
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Pedro Manuel Baeza, 2014-04-18
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Yannick Vaucher @ Camptocamp, 2014-03-21
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Markus Schneider, 2014-03-21
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Yannick Vaucher @ Camptocamp, 2014-03-14
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Maxime Chambreuil (http://www.savoirfairelinux.com), 2014-01-03
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Markus Schneider, 2014-01-03
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Maxime Chambreuil (http://www.savoirfairelinux.com), 2014-01-03
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Markus Schneider, 2013-12-13
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Omar (Pexego), 2013-12-13
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Pedro Manuel Baeza, 2013-11-28
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Markus Schneider, 2013-11-28
-
[Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Markus Schneider, 2013-11-15
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Pedro Manuel Baeza, 2013-11-15
-
Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic
From: Markus Schneider, 2013-11-15