← Back to team overview

openerp-community-reviewer team mailing list archive

Re: [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic

 

Review: Needs Fixing code review, no test

Hi, Markus,

Thank you very much for the new MP.

Some things seeing the code (not functional review yet):

- Lines inside for of _append_childs have an incorrect indentation.
- You should make PEP8 compliance according community guides. You can use flake8 tool to check it on .py files.
-- 
https://code.launchpad.net/~initos.com/account-analytic/7.0/+merge/195362
Your team Account Core Editors is subscribed to branch lp:account-analytic.


Follow ups