openerp-community-reviewer team mailing list archive
-
openerp-community-reviewer team
-
Mailing list archive
-
Message #01417
Re: lp:~agilebg/purchase-wkfl/adding_purchase_order_revision_7 into lp:purchase-wkfl
Review: Needs Fixing code review, no tests
Hi Lorenzo,
Thanks for this contribs ! It looks good to me, even tests included !
Just 2 remarks:
- You just missed at line 27 : from . import purchase
- Please add the .pot file and i18n folder for translation
Regards,
Joël
--
https://code.launchpad.net/~agilebg/purchase-wkfl/adding_purchase_order_revision_7/+merge/193778
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
Follow ups
References