openerp-community-reviewer team mailing list archive

Thread
Date

Re: [Merge] lp:~lin-yu/purchase-wkfl/add_purchase_price_list into lp:purchase-wkfl

To: LIN Yu <lin.yu@xxxxxxxxxxxxxx>
From: Joël Grand-Guillaume @ camptocamp <joel.grandguillaume@xxxxxxxxxxxxxx>
Date: Fri, 15 Nov 2013 15:24:49 -0000
In-reply-to: <20130819073324.10151.25756.launchpad@ackee.canonical.com>
Reply-to: mp+180796@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove code review, no tests

Hi Lin,

Thanks for this contribs ! Do you really need to override the whole function "price_get_multi" without calling super() ? 

This can lead in very unexpected result so for now I marks it as Disapprove for that reason. Other module that may override this method can face trouble due to that...

Thanks for your understanding or explanation if I do missed something !

Regards,
-- 
https://code.launchpad.net/~lin-yu/purchase-wkfl/add_purchase_price_list/+merge/180796
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.