openerp-community-reviewer team mailing list archive

Thread
Date

Re: lp:~savoirfairelinux-openerp/partner-contact-management/city-move into lp:partner-contact-management

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: Pedro Manuel Baeza <pedro.baeza@xxxxxxxxx>
Date: Wed, 20 Nov 2013 22:59:19 -0000
In-reply-to: <20131120220326.11849.61378.launchpad@ackee.canonical.com>
Reply-to: mp+196023@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove

Hi, Sandy,

Sorry, I cannot approve this module, because there is already one module that overlaps totally the functionality of this one: base_location. Indeed, this module was a mix that we did before of old res_better_zip and city modules that were on extra-modules, so maybe the city you are including is very similar to this one.

I suggest you to use this new module as the base for your localisation, the same as Spain and other countries do now.

Regards.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/city-move/+merge/196023
Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management.

References

lp:~savoirfairelinux-openerp/partner-contact-management/city-move into lp:partner-contact-management
From: Sandy Carter (http://www.savoirfairelinux.com), 2013-11-20