openerp-community-reviewer team mailing list archive

[Daniel Reis <dgreis@xxxxxxx>]

Review: Needs Fixing

Some minor nitpicks:

L9: why import osv? I think you can "orm.except_orm()".
L22: I can see it was already there, but maybe you can improve the message (what does "(resp. Sign out)" mean?)
L38,L51: isn't the comment over indented?
L80: turn that comment into a docstring (""" explanation """)

You might also check PEP8; at least line 92 is not compliant.
-- 
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-timesheet-add-department-by-default/+merge/195965
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet.